jenkins-client-217 - Added ability to stream logs and retrieve chunks #219
Conversation
|
Could please offer unit/integration tests....? |
|
@khmarbaise - yes, as said above - I wanted to do it if this idea would be accepted, but there is not much involved to do it anyway. Going to do it now. |
|
I can say that. I already accept your idea and improvements and in particular your contributions...which is really great.... |
wtrocki
force-pushed
the
jenkins-client-217
branch
2 times, most recently
from
41a72b0 to
d52b5c1
Compare
|
Thanks for approval. Final cuts added. Current code base wasn't affected by my changes, only new methods were introduced. Unit tests were added. I reverted pooling method to be blocking. We can squash this into single commit when merging. |
| /** | ||
| * Listener interface used to obtain build console logs | ||
| */ | ||
| public interface BuildConsoleStreamListener { |
There was a problem hiding this comment.
With async version (previous commit) all errors including timeouts were handled by error method here. Since we use now blocking method - (I believe it's more cleaner way to do it that way) , all errors would be handled as exceptions.
|
Can you please take a look onto the travis build cause it's failed.... |
|
Looks like it does pass now: but failed before: |
|
@khmarbaise in case this is merged, can you again publish a new snapsht :) Thanks 🍻 |
|
Any chance to get that merged? |
|
Is it possible to squash all those commits together and make a issue reference in the log as I mentioned in the contribution part of the README... |
wtrocki
force-pushed
the
jenkins-client-217
branch
from
b091881 to
66f8f12
Compare
|
Really sorry. I was confused because in ReleaseNotes reference github issues. I created and referenced github issue before creating this PR: #217 Going to move this to jira now. |
wtrocki
force-pushed
the
jenkins-client-217
branch
2 times, most recently
from
887532c to
41986d5
Compare
|
Failing build item is unrelated with may changes. I tried to run this on my local machine and I was passing! It looks like timing issue. |
wtrocki
force-pushed
the
jenkins-client-217
branch
2 times, most recently
from
59beea5 to
3a8bf5a
Compare
|
Tried to resolve problem. It looks like master is broken, but only on travis. |
|
works on my box as well :-(
…On Thursday, 5 January 2017, Wojciech Trocki ***@***.***> wrote:
Tried to resolve problem. It looks like master is broken, but only on
travis.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJnzqD7PVKYofvqA-I5AGt0SBDtrMP3ks5rPS_8gaJpZM4LQtvb>
.
--
Sent from Gmail Mobile
|
wtrocki
force-pushed
the
jenkins-client-217
branch
from
3a8bf5a to
ae589d5
Compare
|
Yes the master had an issue sorry for that. Now the master is fixed (my fault ;-((). |
wtrocki
force-pushed
the
jenkins-client-217
branch
from
ae589d5 to
4c59d43
Compare
|
Build is passing. Can we get that merged? |
Motivation
Allow to stream logs for ongoing builds.
Current methods doesn't allow that and users need to wait for entire build to get full build log.
This PR is implementation for #217